fix: improve api usage #475
Merged
+12
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release-as: 9.5.0
There was a problem hiding this comment.
Pull request overview
This PR improves API usage across the closure_tree gem by making internal methods private, removing unused test code, using public APIs instead of private methods, and consolidating CI environment variables.
- Renames and privatizes the
adopt_children_to_grandparentmethod to_ct_adopt_children_to_grandparentto follow internal naming conventions - Replaces
connection.send(:arel_visitor)with the publicconnection.visitorAPI - Removes unused hierarchy query calls in adoption tests and consolidates CI environment variables
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/closure_tree/adopt_test.rb | Removed unused hierarchy query calls that had no side effects |
| lib/closure_tree/hierarchy_maintenance.rb | Renamed method to follow _ct_ naming convention and made it explicitly private |
| lib/closure_tree/arel_helpers.rb | Changed from using send(:arel_visitor) to public visitor method |
| .github/workflows/ci.yml | Moved environment variables to job level and added Rails 7.2 to test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@vsmay98 ^^ let test it . then i will release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release-as: 9.5.0